-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding offline_stub_SUITE #3142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3142 +/- ##
==========================================
- Coverage 79.52% 79.49% -0.04%
==========================================
Files 397 397
Lines 32320 32321 +1
==========================================
- Hits 25704 25695 -9
- Misses 6616 6626 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, ready otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
f9b10ed
to
502f8a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
…n offline_stub_SUITE
502f8a1
to
7fcc1e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still 👍🏽 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, just waiting for CI now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
mod_offline_stub doesn't require any conversion to support dynamic domains. Just added some simple offline_stub_SUITE to ensure that it's working correctly w/o any changes.